Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making it work with react-native 0.63.X #57

Closed
ms88privat opened this issue Jul 5, 2020 · 8 comments
Closed

Making it work with react-native 0.63.X #57

ms88privat opened this issue Jul 5, 2020 · 8 comments

Comments

@ms88privat
Copy link

The Podfile of IOS looks different now:

require_relative '../node_modules/react-native/scripts/react_native_pods'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'

platform :ios, '10.0'

target 'RNApp' do
  config = use_native_modules!

  use_react_native!(:path => config["reactNativePath"])

  target 'RNAppTests' do
    inherit! :complete
    # Pods for testing
  end

  # Enables Flipper.
  #
  # Note that if you have use_frameworks! enabled, Flipper will not work and
  # you should disable these next few lines.
  use_flipper!
  post_install do |installer|
    flipper_post_install(installer)
  end
end

target 'RNApp-tvOS' do
  # Pods for RNApp-tvOS

  target 'RNApp-tvOSTests' do
    inherit! :search_paths
    # Pods for testing
  end
end

So in order to make it work,
I needed to search & replace also
node_modules/@react-native-community with ../../node_modules/@react-native-community
and adjust the podfile
use_react_native!(:path => config["reactNativePath"])with use_react_native!(:path => './../../../node_modules/react-native/')

Hope that helps somebody else 👋

@SRandazzo
Copy link

Thanks this helped me!
I had to make one other change per this thread: facebook/react-native#29371

use_react_native!(:path => config[:reactNativePath])

RN version 0.63.2
Yarn workspace via lerna

@sobernaut
Copy link

sobernaut commented Sep 1, 2020

Thanks guys!
@ms88privat @SRandazzo was really stuck with this for long.

It be noted that, you have to change path to /node_modules/hermes-engine and /node_modules/jsc-android in android and android/app's build.gradle file as well. To make it work on android.

@romtrix
Copy link

romtrix commented Sep 6, 2020

How do I upgrade from 0.61.4 to 0.63.2?
https://react-native-community.github.io/upgrade-helper/?from=0.61.4&to=0.63.2
Using upgrade-helper looks tedious to update line by line.
I suppose @brunolemos is too busy or doesn't see a point to upgrade this repository.

@exzos28
Copy link

exzos28 commented Oct 26, 2020

https://github.com/exzos28/react-native-web-monorepo

with rn 0.63.3

@brunolemos
Copy link
Owner

I'll wait for 0.64 to upgrade this repo

@ecklf
Copy link

ecklf commented Oct 28, 2020

I have a working setup in terms of building the app, but I am running into another problem.
My web project uses react v17 and it seems there is a metro bundler / hoisting issue.

I keep getting errors with "invalid hook calls" as described here: facebook/react-native#29722. Has anyone found a fix for this?

@cauyyl
Copy link

cauyyl commented Nov 10, 2020

awesome, you need to pay attention at that make sure node_modules path is right

@brunolemos
Copy link
Owner

brunolemos commented Nov 22, 2020

Hi, this repo is now updated to react-native v0.63.3 and create-react-app v4. I also added nextjs as an alternative to cra. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants